Duplication ofvariables in text.php [MfH 3.3.1]

Forum dedicated to Mods for HESK created by Mike Koch

Moderator: mkoch227

Post Reply
topoldo
Posts: 51
Joined: Wed Sep 21, 2016 10:44 am

Duplication ofvariables in text.php [MfH 3.3.1]

Post by topoldo »

Dear Mike,
while I 'm translating MfH into Italian, in the original text.php file I found 3 duplicated variables I reported below.
They were associated to a little bit different text so I don't know if they really have a different meaning and should be splitted into different variables or if they are the same and differences into string association was responsible for their dupliation.

Anyway here they are:

$hesklang['err_custname']='Please enter name(s) for selected optional field(s)';
$hesklang['err_custname']='Enter custom field name';

$hesklang['opt4']='Options for this checkbox, enter one option per line. Each line will be a choice your customers can choose from, multiple choices are possible. You need to enter at least two options!';
$hesklang['opt4']='Options for this checkbox, enter one option per line. Each line will be a choice your customers can choose from, multiple choices are possible.';

$hesklang['ons']='ON - All';
$hesklang['ons']='ON - Everyone'; // For admin settings page

Cheers,
Topoldo

PS: BTW I did not find any new string to translate with respect to 3.3.0 even if you told me you should have add
$hesklang['sm_contents'] = 'Contents';
mkoch227
Posts: 666
Joined: Wed Jul 04, 2012 3:37 pm

Re: Duplication ofvariables in text.php [MfH 3.3.1]

Post by mkoch227 »

err_custname, opt4, and ons were all changed in HESK 2.7.0, so the same strings were carried forward in Mods for HESK. It looks like Klemen moved the strings from the HESK 0.94 block in the language file, while I just copied over the new versions (leaving the old ones higher up in the file). Since the new values are defined last, they are the ones used on the page. I'll make a note to clean up any duplicates for the next release, but it's currently not causing any issues right now.

Regarding the service messages content string, I decided to re-use the 'kb_contents' language key in the end :wink:
Mike, Lead Developer of Image HESK: A surprisingly simple, user-friendly and FREE help desk software with integrated knowledgebase.
Post Reply