Some mismatch between text.php of Hesk 2.7.5 and MfH 3.2.4

[topoldo]

Hi all.
I'm trying to update my translation into Italian of Hesk 2.7.5 (done, today!) and MfH 3.2.x (in progress).
By ispecting the contens of the two (English) text.php files, I found some discrepancies, ie:

* MfH puts between strings coming from Hesk 0.94
$hesklang['wait_staff_reply']='Waiting reply from staff';
$hesklang['wait_cust_reply']='Waiting reply from customer';
but checking text.php of Hesk 2.7.5 these two strings/variables are not present

* MfH puts in between strings added/modified by MfH itself some strings which, are already present in Hesk, ie:
$hesklang['addnote'] = 'Add note'; (ADDED OR MODIFIED IN Mods For HESK 1.6.0)
$hesklang['nti']='New ticket'; (ADDED OR MODIFIED IN Mods For HESK pre-1.2)
$hesklang['close_this_ticket']='Close ticket'; (ADDED OR MODIFIED IN Mods For HESK 1.2)

IMHO this causes confusion to translators who, like me, have to checck every time if the two files are consistant or not.
This is especially true for strings removed from Hesk but which persist into MfH like the two I reported above.
My 2 cents tip.
Regards,
Topoldo

[Klemen]

Thank you for your Italian translation contributions!

I think the issue comes because Hesk translated language files are now being generated automatically and MfH uses old version of the text.php (which may also include strings that are used in older Hesk version, but not in 2.7.5).

My recommendation to Mike would be to in the future remove all MfH text from text.php and rather place it in a separate file, like text-mfh.php, loaded after text.php (and before custom-text.php). This way the underlying text.php file will always be the original one (original translation) and translators will only need to focus on the text-mfh.php file and any other new MfH files, without having to make changes to the text.php again.

Mike is the author of MfH so the ultimate decision how he wants to organize MfH translations is up to him, of course.

[topoldo]

The idea of Klemen is good.
Alternatively my suggestion is this: Klemen & Mike please report in full into the changelog the variables $hesklang which were removed or modified at every new release of Hesk and MfH, if this happens.
A third possibility is to contact translators before or immediately after a new release of Hesk/MfH involving modifications or deletion of $hesklang variables and report them the list.
Addition of $hesklang variables is not important because if this happens it is clearly indicated into the files.
My two cents tip.
Regards,
Topoldo