Missing Data

FruitBeard · Post by **FruitBeard** » Fri May 12, 2006 4:07 am

Hello Hello Hello,

I have been sniffing around GBook 1.4 and I do like what has materialised.

One little point which i find frustrating is:

If you enter any data on the sign guestbook fields and try to add it with one of the required fields missing. You lose all previous input data.

Yep, it tells you that the unfilled textfield is needed (good), but when returning to the form all other data is missing.

This also does this with your very own phpjunkyard demo guestbook.

I was wondering if this was easy to remedy.

Maybe if I played around I could find it.

Any assistance most welcome.

P.s i.m still using 1.35, 1.4 is locally used at present

Post by **Klemen** » Fri May 12, 2006 8:54 pm

Hi,

True, this is because sessions are now started on the "add entry" page and sessions clear browser cache (every time you open the signup page your browser refreshes it, that's why all the info is missing).

How about something like this:
http://www.phpjunkyard.com/extras/gbook141.zip
Haven't had the time to test it thoroughly yet, any comments/your testing welcome.

Regards

Henrie · Post by **Henrie** » Fri May 12, 2006 9:17 pm

It works partly.
When you fill the e-mail or website not according to the rules it just clears them and continues to the anti-span check without a warning that these fields are not filled correctly and should be corrected before posting the message.

Greetings,
Henrie

Post by **Klemen** » Fri May 12, 2006 9:38 pm

How about now, the same file but updated:
http://www.phpjunkyard.com/extras/gbook141.zip

Should work even with Javascript disabled.

FruitBeard · Post by **FruitBeard** » Fri May 12, 2006 11:26 pm

Hi there,

Thanks for doing the things that you did.

Both beta versions (if you wish to call them that) worked and the comment from henry was true about the first version of the two links.

The javascript one seemd to iron out the email and url wrong inputs, but personally i blooming well dislike those annoying pop up javascript boxes, especially the sound (I know you can turn it off).

I have plumped for my own modified version of 1.4 ( which is now up and running). I basically removed sessions, due to the fact that i have a preview notes before submission area, where upon the sesions stopped you from doing it properly.

It still uses junkmark etc etc

I've also done some nice things with the reply to post function and the sign guestbook function.

CHEERS

Henrie · Post by **Henrie** » Sat May 13, 2006 7:06 am

I also dislike the javascript solution.
I liked the way it was done in version 1.35 .
Your first solution with the text displaying was better than the second with the popup but it also cleared the invalid e-mail and website, which it should not do.

The perfect solution for me would be the javascript check solution but not display the error with an alert box but with a text display like it is done in the first solution.

I hope you know a way to achieve this, or maybe I will think of a way to do it myself when I upgrade the xhtml version.

Greetings,
Henrie

Post by **Klemen** » Sat May 13, 2006 12:54 pm

Hi,

Well, like said sessions start on the signup page now in 1.4 and to have it setup the way it was in 1.35 (with the "Go back" link) will erase all data now because session pages are not stored in browser cache. having sessions started on the signup page helps a great deal in preventing SPAM because of a simple trick (I don't want to discuss it here).

Since blocking spam is the n1 priority for majority of GBook users I spoke to we must find some new ways of displaying errors. What I have done now is updated the first solution a little, if an invalid URL/email is entered it will be deleted and an error will display:
http://www.phpjunkyard.com/extras/gbook141_rev3.zip

What would you like better - this one above or having the error displayed like in 1.35 and when clicking "Go back" link they would be taken to
gbook.php?a=sign&name=...&email=...&url=...
and having fields populated then from the query string?

In my opinion 141_rev3 is better than 1.35 way (plus the long query string) because it reduces the number of steps (they don't have to click any links to get back to the signup form).

Any thoughts/suggestions welcome.

Regards

Henrie · Post by **Henrie** » Sat May 13, 2006 3:36 pm

This version of Gbook (141_rev3) works great for me. This is what i meant in my previous posting.
And indead it is great not to have to click the Back to page link to correct the faulty entered field.

Thanks for changing it. I will surely use this version of the script.

Greetings,
Henrie