"Features" in 2.6.7 (and some in older versions)

[Treblig]

Script URL:
Version of script: 2.6.7
Hosting company:
URL of phpinfo.php:
URL of session_test.php:
What terms did you try when SEARCHING for a solution: unmatched tag

Write your message below:
Hi,
I've made so many changes to my (old and trusty) Hesk install that I find it necessary to start afresh and re-apply all the changes like mandatory logging, moving stuff to css file, etc. but that's another story.

I found a few "features" in Hesk, some seem to be carried over from older versions. Here are a few of them, if I find more, I'll add them in this topic.

On a fresh 2.6.7 install, in admin/index.php, there's an unmatched </a> tag on line 361:

Code: Select all

<p><b><?php echo $hesklang['admin_login']; ?></a></b></p>

in header.inc.php there's an obsolete attribute language="Javascript" on line 44:

Code: Select all

<script language="Javascript" type="text/javascript" src="<?php echo HESK_PATH; ?>hesk_javascript.js"></script>

This is true for all occurrences in many files.

in show_search_form.inc.php there's a missing </label> tag on line 145:

Code: Select all

<td width="33%"><label><input type="checkbox" name="s5" value="1" <?php if (isset($status[5])) {echo 'checked="checked"';} ?>  /> <span class="onhold"><?php echo $hesklang['on_hold']; ?></span></td>

in admin_settings there's a "<select>" instead of "</ select>" on line 1048.

in show_search_form.inc.php there are a couple of "<td stlye=" instead of "<td style=" around line 375

in manage_categories.php there's an unmatched </p> tag on line 310:

Code: Select all

<input type="submit" value="<?php echo $hesklang['create_cat']; ?>" class="orangebutton" onmouseover="hesk_btn(this,'orangebuttonover');" onmouseout="hesk_btn(this,'orangebutton');" /></p>

in manage_knowledge_base there's an unmatched "</span>" tag (the last one) on line 2236:

Code: Select all

    <img src="../img/blank.gif" width="1" height="16" alt="" style="padding:1px" class="optionWhiteNbOFF" />(<span class="kb_published">1</span>, <span class="kb_private">2</span>, <span class="kb_draft">3</span>) = <?php echo $hesklang['xyz']; ?></span><br />

in knowledge_base_private there's an unmached "</a>" tag on line 598:

Code: Select all

	<img src="../img/edit.png" width="16" height="16" alt="<?php echo $hesklang['edit']; ?>" title="<?php echo $hesklang['edit']; ?>" border="0" style="border:none;vertical-align:text-bottom" /></a> <input type="hidden" name="a" value="edit_article" /><?php echo $hesklang['aid']; ?>: <input type="text" name="id" size="3" <?php if ($artid) echo 'value="' . $artid . '"'; ?> /> <input type="submit" value="<?php echo $hesklang['edit']; ?>" class="orangebutton" onmouseover="hesk_btn(this,'orangebuttonover');" onmouseout="hesk_btn(this,'orangebutton');" />

in admin_settings there are a couple of self-closing "<textarea ... />" followed by a "</textarea>"

General notes :
There are many "<a" tags that have an "alt" attribute. "alt" is not an attribute of "<a" tags.

There's a lot of hard coded styles and attributes (many deprecated BTW, like most "width=", "align=", "border="etc.).
Round corners are now pretty easy to do in css instead of using images. In my old install, I have changed (almost) all the styles and attributes to css and that allows to change things on the interface "on the fly".
Is there a plan to move more stuff to the css file ?

[Klemen]

Thanks for reporting html tag mismatches, will fix those.

Note that Hesk is still in XHTML 1.0 Transitional doctype, so things like image alt are required to validate (even if removed in HTML5 which your validator probably validated against?).

There is indeed a plan to move to a more modern interface, but I have been promising it for so long I don't want to give any more false promises here...