Page 1 of 1

Small bug on 1st post (hesk 2.2)

Posted: Mon Jun 21, 2010 2:47 am
by andreofgyn
Hi,

When you post the first message of the ticket (submit_ticket.php and admin_submit_ticket.php), the message is not formatted (breaklines and urls).

I take a look and the formatted $message variable is not being used on insert.

This is visible at the hosted demo of hesk too.

Great job, by the way.

Posted: Mon Jun 21, 2010 8:15 am
by Klemen
Oh my, no idea how that got pass all the testing.

Thanks for the heads up, it's been corrected now. Simply download Hesk again and upload the two files again:
- submit_ticket.php
- admin/admin_submit_ticket.php

Posted: Mon Jun 21, 2010 12:54 pm
by andreofgyn
Hello, Klemen,

Thanks for the answer.

Another one:

The variable $email is used, but not set on admin_submit_ticket.php, so, no e-mail to the customer. I changed to $_POST['email'] and works good. Around line 295.

Posted: Mon Jun 21, 2010 3:48 pm
by Klemen
You're right, thanks again.

However, you should use $tmpvar['email'] instead of $_POST['email'] as the $tmpvar variable has been properly validated.

If you find anything else please do let me know.