Page 1 of 1

Guestbook tips next version

Posted: Wed Nov 05, 2008 10:40 am
by Ruud
Script URL:
Version of script: 1.6
Hosting company:
URL of phpinfo.php:
URL of session_test.php:
What terms did you try when SEARCHING for a solution:

Write your message below:
[1]
As for now the images, holding Delete, IP and Reply containes an ALT with tooltip text. Sufficient for IE users. Firefox users will see nothing, because FF uses the title instead. Rather easy to implement at two places in Gbook.php at about line 558 and 1017 : copy the alt , past behind it, and change the second "alt" to "title" , but perhaps even simple to implement in a next version :wink:

[2]
Because of the stylesheet item div class centered = center, and the hidden software, the page counting/displaying is centered but also the text in the table-td.
Personally I don't like that, easy to change with an extra item in the stylesheet :
td { text-align:left }

Installed the script, posted a message, works nicely, use it as a Micro Blog. Well done , Klemen, thanks. :D

Posted: Wed Nov 05, 2008 6:44 pm
by Henrie
Hi Ruud,

I have also explained the title problem to Klemen once.

The stylesheet has more problems.
Standard the body and td styles should be split.
Also some styles (like widths and center and more)are hardcoded in the gbook.php file. They should also be moved to the style.css file.

Maybe Klemen will do this in the future version.

Klemen, i think you know how to do it yourself, but if you need help. I am willing to help.

Greetings,
Henrie

Posted: Wed Nov 05, 2008 7:07 pm
by Klemen
Added to my "to do" list. In case I release any minor update first (for example just an anti-spam update) it might not be yet included, but definitely something to be added.

Posted: Wed Nov 05, 2008 8:07 pm
by Ruud
Hello Henrie,

Two Dutchmen for the comments and Klemen for President ? ( He has to do the job :lol: ).

@Klemen: there's no time problem, I made of course the changes already, the only problem is in case of an update, to not forget this modifications.

I have a very little contribution to your to-do list : I love to have for each webpage a Tidy 100% perfect score, not for fun, for security reasons, knowing all runs well. At this moment, there are 2 messages on my micro blog, and a Tidy warning. So I looked around, the VAR $gbook_nav will be empty if there's only 1 page, resulting at about line 247 in an empty paragraph and that's a yellow card from Tidy. Replacing line 247 with :
echo '<p>&nbsp;'.$gbook_nav.'</p>';
, problem solved. Never ever an empty var problem because of the 160-space, even for the first page.8)