Page 2 of 2

Re: HESK version 2.7.0 BETA 2 (test version)

Posted: Fri Oct 21, 2016 9:08 pm
by Lisaweb
Pretty sure this is a bug. In the Ticket List Settings, if I uncheck the "Subject' field (since we don't need it) then all the fields are off. See screenshot of before / after....

Normal
Image

Fields off kilter: Due date shows customer name field (ID:4), other fields off, ect...
Image

Re: HESK version 2.7.0 BETA 2 (test version)

Posted: Sat Oct 22, 2016 10:27 am
by Klemen
Good job, Lisa, you indeed found two bugs.

The date bug is a display bug; the "+0 days" value is saved and works correctly, but in the form it shows as "Any date".

The second bug happens when none of the "ID, Tracking ID or Subject" fields are selected for display. Hesk requires at least one (to generate a link to the ticket), so the "Tracking ID" was being added as the last column title when it should have been added as the first one.

You can temporarily fix the second bug in your help desk by going into "Settings" and clicking "Save changes" without making any changes.

I fixed both these issues in my code and will post "Beta 3" update here later today or tomorrow.


P.s.: did the "common.inc.php" I sent over email fix the piping issue you had?

Re: HESK version 2.7.0 BETA 2 (test version)

Posted: Sun Oct 23, 2016 1:35 am
by mkoch227
Looking at hesk_javascript.js, I see the following function arg in hesk_suggestEmail:

Code: Select all

allowMultiple=0
According to the MDN, default parameters were introduced in ES6. This will cause browsers that don't support ES6 to fail, expecting either a comma or closing parenthesis.

Proposed solution: Remove the default parameter and add either an undefined check or use a logical OR operator (below):

Code: Select all

allowMultiple = allowMultiple || 0;

Re: HESK version 2.7.0 BETA 2 (test version)

Posted: Sun Oct 23, 2016 12:47 pm
by Klemen
Good point, this could result in Syntax errors in older browsers.

I decided to simply remove "=0" from the function arguments since allowMultiple is only used within an if statement and "undefined" brings the same result as defaulting to 0.

Re: HESK version 2.7.0 BETA 3 (test version)

Posted: Sun Oct 23, 2016 4:38 pm
by Klemen
HESK 2.7.0 beta 3 has been released.

You will find the download file (and diff, Mike :wink: ) in the first post.

==> Install or update BETA 1/2 to BETA 3

Just like any HESK install/update, follow instructions in the docs.

Don't forget to backup files before uploading and make sure you don't upload the new "hesk_settings.inc.php" file! There are also changes in the language files, don't forget to upload those!

==> Changes from beta 2

- fixed autorefresh still enabled
- fixed 20 to 50 in edit_post.php
- custom radio filed; option to not select a default value
- modified default staff permissions to match 2.6.x default permissions
- redirect to correct page when editing KB articles from List private/draft
- in "Tickets per user" report show how many tickets a user has submitted
- in staff interface handle hidden fields as text fields
- clean custom field values in admin panel after submitting ticket
- don't force SSL from CLI (for email piping/fetching)
- fixed min/max date "+X days" format display when X = 0
- fixed the issue with "ticketid" column title in last position, not first
- removed default value from hesk_suggestEmail allowMultiple
- changed domain used in examples/defaults to example.com
- some other minor tweaks

Re: HESK version 2.7.0 BETA 3 (test version)

Posted: Mon Oct 24, 2016 1:31 am
by mkoch227
Klemen wrote:and diff, Mike :wink:
You know me too well :lol:

Re: HESK version 2.7.0 BETA 2 (test version)

Posted: Mon Oct 24, 2016 11:22 pm
by Lisaweb
Klemen wrote:

P.s.: did the "common.inc.php" I sent over email fix the piping issue you had?
Sorry Klemen, didn't get it - but I think it's because I had an old email address in my profile. I've updated it to my latest email address, would you kindly send it over again? Thanks! :)

Re: HESK version 2.7.0 BETA 3 (test version)

Posted: Tue Oct 25, 2016 7:12 am
by Klemen
It's been included in beta 3, so you can simply use the common.inc.php from beta 3.

Re: HESK version 2.7.0 RC 1 (release candidate)

Posted: Mon Oct 31, 2016 9:06 am
by Klemen
HESK 2.7.0 RC 1 (release candidate) has been released.

This is the last planned preview before 2.7.0 is officially released.

Downloads are in the first post.

==> Install or update BETA to RC

Just like any HESK install/update, follow instructions in the docs.

Don't forget to backup files before uploading and make sure you don't upload the new "hesk_settings.inc.php" file! There are also changes in the language files, don't forget to upload those!

==> Changes from beta 3

- added "Refresh this page" link to customer ticket page
- in customer ticket page remember ticket ID and email when changing language
- KB articles can be deleted from the "Edit article" page
- detect if HESK hasn't been installed yet and show link to docs instead of "maintenance mode" message
- moved temporary files out of attachments folder to cache folder
- fixed backslashes issue with email templates
- other minor changes

Re: HESK version 2.7.0 RC 1 (release candidate)

Posted: Sat Nov 12, 2016 1:37 am
by J_E_F_F
It looks like paypal changed their payment notification emails earlier this week. Now when receiving one into Hesk (2.6.8) instead of populating the ticket with the correct Name and email address, they use Paypal and service@paypal.com respectively, and it generates an autoresponse which bounces back from paypal. Not sure if this is relevant or not, but we came up with this similar fix in March 2015 viewtopic.php?f=13&t=5057&p=22830#p22830

I'm hoping this paypal change can be corrected in the next Hesk version or via specific code as before. I can provide more specific detail via PM if necessary as the ticket created does contain private information that I'd not want to post in public, such as the users email address and transaction info.

Re: HESK version 2.7.0 RC 1 (release candidate)

Posted: Sat Nov 12, 2016 8:52 am
by Klemen
Please send a sample email (I need only the email headers) to me in a PM, I will have a look.

Re: HESK version 2.7.0 RC 1 (release candidate)

Posted: Mon Nov 14, 2016 1:01 am
by J_E_F_F
thanks, PM sent

Re: HESK version 2.7.0 RC 1 (release candidate)

Posted: Mon Nov 14, 2016 9:58 am
by Klemen
They complicated things now (not to mention their emails are full of coding mistakes...). Try this: viewtopic.php?f=13&t=5057&p=24847#p24847