Page 2 of 5
Re: HESK version 2.3 BETA (test version)
Posted: Fri Aug 19, 2011 12:23 pm
by Klemen
Sending emails are now handled by the "hesk_mail" function, located in the inc/email_functions.inc.php file.
You can simply add something like this to the top of the function to disable all emails:
Code: Select all
function hesk_mail($to,$subject,$message) {
return false;
/* the rest of the code may be left intact... */
Re: HESK version 2.3 BETA (test version)
Posted: Fri Aug 19, 2011 11:23 pm
by SS113
perfect! Thank you!
So far this is great! no bugs found yet
Re: HESK version 2.3 BETA (test version)
Posted: Sun Aug 21, 2011 1:40 am
by SS113
Quick question about 2.3.
I see that it has a "lastchange" that calculates how long it has been since the ticket was last changed. While it works great, it shows up as: 1d22h instead of 1d 22h. Is it possible to add a space between them?
Thanks
Re: HESK version 2.3 BETA (test version)
Posted: Sun Aug 21, 2011 7:39 am
by Klemen
That was done on purpose to save space for other information.
But you can still add space by modifying the text used in language/en/text.php:
1. find
a space after
y, so it looks like:
2. Do the same for other abberivations below this line
Re: HESK version 2.3 BETA (test version)
Posted: Sun Aug 21, 2011 6:03 pm
by SS113
Thanks! That looks much better.
To combat the space issue (since I modified what columns shows up in admin_main.php, I changed the width in hesk_style_v23.css from 770px to 970px and it's much wider and everything fits very nicely!
Thanks again
Re: HESK version 2.3 BETA (test version)
Posted: Sun Aug 21, 2011 6:08 pm
by SS113
I *may* have found a bug!
when you go to the settings, under the Help Desk tab, there's an option to auto close tickets after x days.
It shows up as:
Autoclose tickets: [?] [7] days after last staff reply
but if I try to disable that to 0, it saves it successfully but it goes back to 7 days right after that
Is this a bug or?
Re: HESK version 2.3 BETA (test version)
Posted: Sun Aug 21, 2011 6:33 pm
by Klemen
Indeed a bug. Good catch, thanks for reporting it
Re: HESK version 2.3 BETA (test version)
Posted: Sun Aug 21, 2011 6:42 pm
by SS113
Klemen wrote:Indeed a bug. Good catch, thanks for reporting it
Yesss!! I feel important! haha just kidding!
anyway, I guess a workaround for now would be to set it to 365 days or so and don't worry about it
Re: HESK version 2.3 BETA (test version)
Posted: Sun Aug 21, 2011 7:15 pm
by Klemen
You should feel important, every even smallest bug report is very important
You can modify file admin/admin_settings_save.php lines 100 and 101 to say
Code: Select all
$set['autoclose'] = ! isset($_POST['s_autoclose']) ? 7 : intval($_POST['s_autoclose']);
$set['autoclose'] = hesk_checkMinMax($set['autoclose'],0,999,7);
Re: HESK version 2.3 BETA (test version)
Posted: Mon Aug 22, 2011 1:25 am
by SS113
Klemen wrote:You should feel important, every even smallest bug report is very important
You can modify file admin/admin_settings_save.php lines 100 and 101 to say
Code: Select all
$set['autoclose'] = ! isset($_POST['s_autoclose']) ? 7 : intval($_POST['s_autoclose']);
$set['autoclose'] = hesk_checkMinMax($set['autoclose'],0,999,7);
Are you sure it's that file name/line?
my admin/admin_settings.php at line 100 and 101 say:
Code: Select all
if (d.s_site_title.value=='') {alert('<?php echo addslashes($hesklang['err_sname']); ?>'); return false;}
if (d.s_site_url.value=='') {alert('<?php echo addslashes($hesklang['err_surl']); ?>'); return false;}
I tried changing them to that and adding them above it and it still has the bug...
Re: HESK version 2.3 BETA (test version)
Posted: Mon Aug 22, 2011 9:33 am
by devcoder1
Klemen wrote:One possible reason that comes to mind is your DB structure is not 100% compatible with 2.3. Check structure of table "hesk_tickets" and see if "trackid" is varchar(10) or varchar(13)? Should be varchar(13), if it's not the ticket ID is getting truncated when it enteres the DB.
In this case, you would have a ticket with trackind ID "5YE-LNJ-6R" ("NX" missing) in the database instead of a ticket with the correct ID "5YE-LNJ-6RNX".
Hi Klemen
This seems like it could be the issue will check and let you know.
No all the files are from 2.3 - the database is from 2.2 - but EVERYTHING works - except when you go to open a new ticket from inside the admin control panel - but will check the varchar etc and get back to you.
Thanks,
Thomas
Re: HESK version 2.3 BETA (test version)
Posted: Mon Aug 22, 2011 9:36 am
by devcoder1
Klemen wrote:This happens when you click "+ New ticket" link or when you enter info and submit the form?
Do you get the same error if you Unselect "Show the ticket after submission"?
Does the ticket get entered in the database?
Are you sure the database structure is from 2.3 and not from 2.2?
Double-check that admin_ticket.php and other files are the ones from version 2.3 and not 2.2.
Yes the ticket gets entered into the database, it just does not show it through the webpage after you have submitted ticket and instead gives the error (which is the screenshot I uploaded)
Re: HESK version 2.3 BETA (test version)
Posted: Mon Aug 22, 2011 1:31 pm
by Klemen
@SS113: you should edit file "admin_settings
_save.php", not "admin_settings.php"
@devcoder1: could you post a sample ticket tracking ID (one of the new format with the "-") that you see from the
admin panel main page?
Re: HESK version 2.3 BETA (test version)
Posted: Wed Aug 24, 2011 2:21 am
by SS113
Klemen wrote:@SS113: you should edit file "admin_settings
_save.php", not "admin_settings.php"
I swear you went back and added the _save.php part!
anyway, it works great now! Thanks again! I'll keep hunting for more bugs but it looks pretty stable to me!
Re: HESK version 2.3 BETA (test version)
Posted: Wed Aug 24, 2011 3:06 pm
by Klemen
No, you are just getting old
Anyway, I found and fixed few other minor problems and will probably release 2.3 officially in a week. If you find anything else do let me know.