Small bug on 1st post (hesk 2.2)

Helpdesk for my helpdesk software

Moderator: mkoch227

Post Reply
andreofgyn
Posts: 4
Joined: Mon Jun 21, 2010 2:35 am

Small bug on 1st post (hesk 2.2)

Post by andreofgyn »

Hi,

When you post the first message of the ticket (submit_ticket.php and admin_submit_ticket.php), the message is not formatted (breaklines and urls).

I take a look and the formatted $message variable is not being used on insert.

This is visible at the hosted demo of hesk too.

Great job, by the way.
Klemen
Site Admin
Posts: 10145
Joined: Fri Feb 11, 2005 4:04 pm

Post by Klemen »

Oh my, no idea how that got pass all the testing.

Thanks for the heads up, it's been corrected now. Simply download Hesk again and upload the two files again:
- submit_ticket.php
- admin/admin_submit_ticket.php
Klemen, creator of HESK and PHPJunkyardWas this helpful? You can buy me a drink here Image

Image You should follow me on Twitter here

Help desk software | Cloud help desk | Guestbook | Link manager | Click counter | more PHP Scripts ...

Also browse for php hosting companies, read php books, find php resources and use webmaster tools
andreofgyn
Posts: 4
Joined: Mon Jun 21, 2010 2:35 am

Post by andreofgyn »

Hello, Klemen,

Thanks for the answer.

Another one:

The variable $email is used, but not set on admin_submit_ticket.php, so, no e-mail to the customer. I changed to $_POST['email'] and works good. Around line 295.
Klemen
Site Admin
Posts: 10145
Joined: Fri Feb 11, 2005 4:04 pm

Post by Klemen »

You're right, thanks again.

However, you should use $tmpvar['email'] instead of $_POST['email'] as the $tmpvar variable has been properly validated.

If you find anything else please do let me know.
Klemen, creator of HESK and PHPJunkyardWas this helpful? You can buy me a drink here Image

Image You should follow me on Twitter here

Help desk software | Cloud help desk | Guestbook | Link manager | Click counter | more PHP Scripts ...

Also browse for php hosting companies, read php books, find php resources and use webmaster tools
Post Reply